Skip to content

build: update to latest ts-node version #19399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

The dev-infra package has an optional peer dependency
on ts-node for supporting TypeScript-based configurations.

This highlighted that we currently are behind the latest version
by a good amount. We should update so that the peer dependency
is satisified and generally for the sake of benefiting from the
latest ts-node changes (like better diagnostic messaging).

This commit additionally fixes compilation issues in the
caretaker-resync script and in the breaking changes script.

The dev-infra package has an optional peer dependency
on `ts-node` for supporting TypeScript-based configurations.

This highlighted that we currently are behind the latest version
by a good amount. We should update so that the peer dependency
is satisified and generally for the sake of benefiting from the
latest `ts-node` changes (like better diagnostic messaging).

This commit additionally fixes compilation issues in the
caretaker-resync script and in the breaking changes script.
@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels May 20, 2020
@devversion devversion requested review from jelbourn and a team as code owners May 20, 2020 10:43
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 20, 2020
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added lgtm action: merge The PR is ready for merge by the caretaker labels May 20, 2020
@jelbourn jelbourn merged commit d7d67e1 into angular:master May 20, 2020
jelbourn pushed a commit that referenced this pull request May 20, 2020
The dev-infra package has an optional peer dependency
on `ts-node` for supporting TypeScript-based configurations.

This highlighted that we currently are behind the latest version
by a good amount. We should update so that the peer dependency
is satisified and generally for the sake of benefiting from the
latest `ts-node` changes (like better diagnostic messaging).

This commit additionally fixes compilation issues in the
caretaker-resync script and in the breaking changes script.

(cherry picked from commit d7d67e1)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants