Skip to content

build: remove cherry-pick-patch script #19400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

We now have a merge script in the components repo. This means that we no
longer need the cherry-pick-patch script. If there are cases where
commits would need to be manually cherry-picked, then the cherry-pick
command could be built up manually too.

We now have a merge script in the components repo. This means that we no
longer need the cherry-pick-patch script. If there are cases where
commits would need to be manually cherry-picked, then the cherry-pick
command could be built up manually too.
@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels May 20, 2020
@devversion devversion requested a review from a team as a code owner May 20, 2020 12:15
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 20, 2020
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added lgtm action: merge The PR is ready for merge by the caretaker labels May 20, 2020
@jelbourn jelbourn merged commit 0faff49 into angular:master May 21, 2020
jelbourn pushed a commit that referenced this pull request May 21, 2020
We now have a merge script in the components repo. This means that we no
longer need the cherry-pick-patch script. If there are cases where
commits would need to be manually cherry-picked, then the cherry-pick
command could be built up manually too.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants