build: remove devmode tsickle decorator processing workaround #19405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
merge safe
target: major
googlebot
added
the
cla: yes
devversion
force-pushed
the
build/remove-tsickle-decorator-processing
branch
from
af1ec39 to
3a20a25
Compare
In the past, we added a workaround for angular/angular#30586, so that tsickle actually runs on the devmode output. We can remove this since there is a more simpler workaround until View Engine is completely gone. Ivy is supposed to fix this unless the output format is modified to preserve TS decorator calls. If that would be the case (it's not at time of writing), then we can still use the global mocking (which is not that unreasonable), or wire up build optimizer (which would be quite complicated in Bazel).
devversion
force-pushed
the
build/remove-tsickle-decorator-processing
branch
from
3a20a25 to
94de333
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, we added a workaround for angular/angular#30586,
so that tsickle actually runs on the devmode output. We can remove this since there
is a more simpler workaround until View Engine is completely gone. Ivy is supposed
to fix this unless the output format is modified to preserve TS decorator calls.
If that would be the case (it's not at time of writing), then we can
still use the global mocking (which is not that unreasonable), or wire
up build optimizer (which would be quite complicated in Bazel).
This is a preparation change for angular/angular#37221, but generally is useful as it simplifies the workaround.