Skip to content

Use new class .mat-button-disabled for applying disabled button styles. #19406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 29, 2020

Conversation

nickwalther
Copy link
Contributor

No description provided.

@nickwalther nickwalther requested a review from jelbourn as a code owner May 20, 2020 18:11
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 20, 2020
@jelbourn jelbourn added target: minor This PR is targeted for the next minor release G This is is related to a Google internal issue labels May 21, 2020
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run a TGP for this? You can create a CL for the change by running our script internally:

javascript/angular/tools/material-presubmit 19406 --create_cl_only

@nickwalther
Copy link
Contributor Author

TGP done

@jelbourn
Copy link
Member

@nickwalther great! One last thing I thought while looking over this again- could you add a comment that explains why the component uses a disabled class instead of the pseudo-selector? Mainly so that someone doesn't come by in the future and try to change it back.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Jun 23, 2020
@jelbourn jelbourn merged commit c2abcad into angular:master Jun 29, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants