docs(stepper): error state example not set up correctly #19416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
mmalerba
approved these changes
May 21, 2020
The `stepper-errors` example was set up using a linear stepper which doesn't allow users to move to a different step if the current one is invalid which means that the user doesn't have a way of seeing the error state. These changes make the stepper non-linear, expand the example description to explain how the error state works, and add some text so users know what to do in order to see the error state. Fixes angular#19407.
crisbeto
force-pushed
the
stepper-error-docs
branch
from
84b9253 to
79a8b76
Compare
andrewseguin
pushed a commit
that referenced
this pull request
Jun 12, 2020
The `stepper-errors` example was set up using a linear stepper which doesn't allow users to move to a different step if the current one is invalid which means that the user doesn't have a way of seeing the error state. These changes make the stepper non-linear, expand the example description to explain how the error state works, and add some text so users know what to do in order to see the error state. Fixes #19407.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
stepper-errorsexample was set up using a linear stepper which doesn't allow users to move to a different step if the current one is invalid which means that the user doesn't have a way of seeing the error state.These changes make the stepper non-linear, expand the example description to explain how the error state works, and add some text so users know what to do in order to see the error state.
Fixes #19407.