Skip to content

test(tooltip/testing): disable tests on touch devices #19447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2020

Conversation

crisbeto
Copy link
Member

Currently the tooltip harness won't work on touch devices, because we don't simulate touch events. These changes temporarily disable the tests on unsupported devices until we can update the harness APIs.

Currently the tooltip harness won't work on touch devices, because we don't simulate touch events. These changes temporarily disable the tests on unsupported devices until we can update the harness APIs.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround merge safe target: major This PR is targeted for the next major release labels May 26, 2020
@crisbeto crisbeto requested a review from andrewseguin as a code owner May 26, 2020 18:34
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 26, 2020
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels May 26, 2020
@jelbourn jelbourn merged commit 0021d2c into angular:master May 26, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants