Skip to content

fix(button-toggle): remove unused property and type ToggleType #19497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2020
Merged

fix(button-toggle): remove unused property and type ToggleType #19497

merged 1 commit into from
Jun 29, 2020

Conversation

stevenyxu
Copy link
Contributor

No description provided.

@stevenyxu stevenyxu requested a review from jelbourn as a code owner June 1, 2020 17:30
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 1, 2020
crisbeto
crisbeto reviewed Jun 2, 2020
View reviewed changes
@crisbeto
Copy link
Member

crisbeto commented Jun 4, 2020

Looks like you still have to update the API golden to remove the underscored property. You can do so by running yarn approve-api material/button-toggle.

@stevenyxu
Copy link
Contributor Author

Thanks. Done.

@crisbeto crisbeto added G This is is related to a Google internal issue lgtm action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jun 4, 2020
jelbourn
jelbourn approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit c225b28 into angular:master Jun 29, 2020
jelbourn pushed a commit that referenced this pull request Jun 29, 2020
@stevenyxu @jelbourn
fix(button-toggle): remove unused property and type ToggleType (#19497)
cf53a70 
(cherry picked from commit c225b28)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto left review comments

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevenyxu @crisbeto @jelbourn @googlebot