fix(sidenav): restore focus if drawer is closed through backdrop click #19534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
P3
googlebot
added
the
cla: yes
crisbeto
reviewed
Jun 4, 2020
devversion
force-pushed
the
fix/drawer-restore-focus-backdrop-click
branch
3 times, most recently
from
47c1ca9 to
956f80f
Compare
Currently we do not restore focus properly when a drawer is closed through backdrop click. This is because we only restore focus when an element inside the drawer is focused before closing. This is not the case when the backdrop is clicked, as the focus is usually redirected to the `document.body` element. Fixes angular#17749.
devversion
force-pushed
the
fix/drawer-restore-focus-backdrop-click
branch
from
956f80f to
70474dc
Compare
mmalerba
approved these changes
Jun 4, 2020
| } else { | ||
| this._elementRef.nativeElement.blur(); | ||
| } | ||
| // Note that we don't check via `instanceof HTMLElement` so that we can cover SVGs as well. |
There was a problem hiding this comment.
Nice, this is definitely easier to understand with the helper broken out
jelbourn
pushed a commit
that referenced
this pull request
Jun 29, 2020
#19534) Currently we do not restore focus properly when a drawer is closed through backdrop click. This is because we only restore focus when an element inside the drawer is focused before closing. This is not the case when the backdrop is clicked, as the focus is usually redirected to the `document.body` element. Fixes #17749.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we do not restore focus properly when a drawer is closed
through backdrop click. This is because we only restore focus when
an element inside the drawer is focused before closing. This is not
the case when the backdrop is clicked, as the focus is usually
redirected to the
document.bodyelement.Fixes #17749.