fix(material-experimental/mdc-menu): missing padding after latest canary release #19548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ary release Fixes the MDC menu item not having side padding anymore. It seems like this broke after the update to the latest canary version, because the padding was moved into a different mixin.
crisbeto
added
P2
googlebot
added
the
cla: yes
mmalerba
added
the
merge: caretaker note
|
Caretaker note: There are a couple screendiffs that will need to be approved (owned by our team) |
andrewseguin
pushed a commit
that referenced
this pull request
Jun 9, 2020
…ary release (#19548) Fixes the MDC menu item not having side padding anymore. It seems like this broke after the update to the latest canary version, because the padding was moved into a different mixin.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Jun 11, 2020
…test canary release (angular#19548)" This reverts commit 771b4ba. This has been accidentally merged into the patch branch, where the MDC version has not been updated yet.
andrewseguin
pushed a commit
that referenced
this pull request
Jun 11, 2020
* Revert "build: switch to chromium provided in dev-infra package (#19565)" This reverts commit b4d0852. * Revert "fix(material-experimental/mdc-menu): missing padding after latest canary release (#19548)" This reverts commit 771b4ba. This has been accidentally merged into the patch branch, where the MDC version has not been updated yet.
andrewseguin
pushed a commit
that referenced
this pull request
Jun 11, 2020
* Revert "build: switch to chromium provided in dev-infra package (#19565)" This reverts commit b4d0852. * Revert "fix(material-experimental/mdc-menu): missing padding after latest canary release (#19548)" This reverts commit 771b4ba. This has been accidentally merged into the patch branch, where the MDC version has not been updated yet.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 13, 2020
Fixes the MDC menu items not having the proper padding. This was fixed initially in angular#19548 and reverted by devversion@b251796, but it was never re-fixed.
mmalerba
pushed a commit
that referenced
this pull request
Jun 17, 2020
Fixes the MDC menu items not having the proper padding. This was fixed initially in #19548 and reverted by devversion@b251796, but it was never re-fixed.
mmalerba
pushed a commit
that referenced
this pull request
Jun 17, 2020
Fixes the MDC menu items not having the proper padding. This was fixed initially in #19548 and reverted by devversion@b251796, but it was never re-fixed.
devversion
pushed a commit
to devversion/material2
that referenced
this pull request
Jun 18, 2020
…ar#19634) Fixes the MDC menu items not having the proper padding. This was fixed initially in angular#19548 and reverted by b251796, but it was never re-fixed.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the MDC menu item not having side padding anymore. It seems like this broke after the update to the latest canary version, because the padding was moved into a different mixin.