-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: switch to chromium provided in dev-infra package #19565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
andrewseguin
merged 1 commit into
angular:master
from
devversion:build/use-chromium-from-dev-infra-pkg
Jun 9, 2020
Merged
build: switch to chromium provided in dev-infra package #19565
andrewseguin
merged 1 commit into
angular:master
from
devversion:build/use-chromium-from-dev-infra-pkg
Jun 9, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeda0ff
to
1c97ad5
Compare
Switches the chromium version provided in the shared dev-infra package. This gives us better control over used versions, and we get RBE optimizations that have been applied to these browsers. Closes angular#19543.
1c97ad5
to
926b18a
Compare
josephperrott
approved these changes
Jun 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
andrewseguin
pushed a commit
that referenced
this pull request
Jun 9, 2020
Switches the chromium version provided in the shared dev-infra package. This gives us better control over used versions, and we get RBE optimizations that have been applied to these browsers. Closes #19543.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Jun 11, 2020
…lar#19565)" This reverts commit b4d0852.
andrewseguin
pushed a commit
that referenced
this pull request
Jun 11, 2020
* Revert "build: switch to chromium provided in dev-infra package (#19565)" This reverts commit b4d0852. * Revert "fix(material-experimental/mdc-menu): missing padding after latest canary release (#19548)" This reverts commit 771b4ba. This has been accidentally merged into the patch branch, where the MDC version has not been updated yet.
andrewseguin
pushed a commit
that referenced
this pull request
Jun 11, 2020
* Revert "build: switch to chromium provided in dev-infra package (#19565)" This reverts commit b4d0852. * Revert "fix(material-experimental/mdc-menu): missing padding after latest canary release (#19548)" This reverts commit 771b4ba. This has been accidentally merged into the patch branch, where the MDC version has not been updated yet.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Jun 23, 2020
Switches the chromium version provided in the shared dev-infra package. This gives us better control over used versions, and we get RBE optimizations that have been applied to these browsers. This is a duplicate of angular#19565 that has been accidentally reverted as a patch-only PR has been merged into `master`. See: angular@d15f19e
jelbourn
pushed a commit
that referenced
this pull request
Jun 26, 2020
Switches the chromium version provided in the shared dev-infra package. This gives us better control over used versions, and we get RBE optimizations that have been applied to these browsers. This is a duplicate of #19565 that has been accidentally reverted as a patch-only PR has been merged into `master`. See: d15f19e
jelbourn
pushed a commit
that referenced
this pull request
Jun 26, 2020
Switches the chromium version provided in the shared dev-infra package. This gives us better control over used versions, and we get RBE optimizations that have been applied to these browsers. This is a duplicate of #19565 that has been accidentally reverted as a patch-only PR has been merged into `master`. See: d15f19e (cherry picked from commit 56ec32b)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
cla: yes
PR author has agreed to Google's Contributor License Agreement
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the chromium version provided in the shared dev-infra
package. This gives us better control over used versions, and we
get RBE optimizations that have been applied to these browsers.
This also fixes that there is no Firefox test target for standalone
web test suites that do not rely on Angular. e.g.
coercion
.Closes #19543.