Skip to content

build: switch to chromium provided in dev-infra package #19565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

devversion
Copy link
Member

@devversion devversion commented Jun 8, 2020

Switches the chromium version provided in the shared dev-infra
package. This gives us better control over used versions, and we
get RBE optimizations that have been applied to these browsers.

This also fixes that there is no Firefox test target for standalone
web test suites that do not rely on Angular. e.g. coercion.

Closes #19543.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 8, 2020
@devversion devversion force-pushed the build/use-chromium-from-dev-infra-pkg branch from eeda0ff to 1c97ad5 Compare June 8, 2020 12:19
Switches the chromium version provided in the shared
dev-infra package. This gives us better control over
used versions, and we get RBE optimizations that have
been applied to these browsers.

Closes angular#19543.
@devversion devversion force-pushed the build/use-chromium-from-dev-infra-pkg branch from 1c97ad5 to 926b18a Compare June 8, 2020 12:54
@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Jun 8, 2020
@devversion devversion marked this pull request as ready for review June 8, 2020 13:01
@devversion devversion requested review from jelbourn and a team as code owners June 8, 2020 13:01
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added lgtm action: merge The PR is ready for merge by the caretaker labels Jun 8, 2020
@andrewseguin andrewseguin merged commit efed41c into angular:master Jun 9, 2020
andrewseguin pushed a commit that referenced this pull request Jun 9, 2020
Switches the chromium version provided in the shared
dev-infra package. This gives us better control over
used versions, and we get RBE optimizations that have
been applied to these browsers.

Closes #19543.
devversion added a commit to devversion/material2 that referenced this pull request Jun 11, 2020
andrewseguin pushed a commit that referenced this pull request Jun 11, 2020
* Revert "build: switch to chromium provided in dev-infra package (#19565)"

This reverts commit b4d0852.

* Revert "fix(material-experimental/mdc-menu): missing padding after latest canary release (#19548)"

This reverts commit 771b4ba.

This has been accidentally merged into the patch branch, where the MDC
version has not been updated yet.
andrewseguin pushed a commit that referenced this pull request Jun 11, 2020
* Revert "build: switch to chromium provided in dev-infra package (#19565)"

This reverts commit b4d0852.

* Revert "fix(material-experimental/mdc-menu): missing padding after latest canary release (#19548)"

This reverts commit 771b4ba.

This has been accidentally merged into the patch branch, where the MDC
version has not been updated yet.
devversion added a commit to devversion/material2 that referenced this pull request Jun 23, 2020
Switches the chromium version provided in the shared
dev-infra package. This gives us better control over
used versions, and we get RBE optimizations that have
been applied to these browsers.

This is a duplicate of angular#19565 that has been accidentally
reverted as a patch-only PR has been merged into `master`.

See:
angular@d15f19e
jelbourn pushed a commit that referenced this pull request Jun 26, 2020
Switches the chromium version provided in the shared
dev-infra package. This gives us better control over
used versions, and we get RBE optimizations that have
been applied to these browsers.

This is a duplicate of #19565 that has been accidentally
reverted as a patch-only PR has been merged into `master`.

See:
d15f19e
jelbourn pushed a commit that referenced this pull request Jun 26, 2020
Switches the chromium version provided in the shared
dev-infra package. This gives us better control over
used versions, and we get RBE optimizations that have
been applied to these browsers.

This is a duplicate of #19565 that has been accidentally
reverted as a patch-only PR has been merged into `master`.

See:
d15f19e
(cherry picked from commit 56ec32b)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(workspace): We need to deduplicate browsers in our WORKSPACE
5 participants