Skip to content

build: switch to dev-infra configuration directory #19581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

devversion
Copy link
Member

We recently updated the shared dev-infra package to the latest
version (in order to bring in the benchmark utils), but this
actually broke the merge script because dev-infra landed a change
on how the configuration is loaded.

Previously, the configuration has been loaded from a single file
at project root, but now dev-infra loads it from a dedicated
dev-infra folder. This has been done that way to allow for dedicated
configuration files for individual ng-dev command parts.

@devversion devversion added P2 The issue is important to a large percentage of users, with a workaround merge safe target: patch This PR is targeted for the next patch release labels Jun 9, 2020
@devversion devversion requested review from jelbourn and a team as code owners June 9, 2020 19:34
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 9, 2020
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added lgtm action: merge The PR is ready for merge by the caretaker labels Jun 9, 2020
We recently updated the shared dev-infra package to the latest
version (in order to bring in the benchmark utils), but this
actually broke the merge script because dev-infra landed a change
on how the configuration is loaded.

Previously, the configuration has been loaded from a single file
at project root, but now dev-infra loads it from a dedicated
dev-infra folder. This has been done that way to allow for dedicated
configuration files for individual `ng-dev` command parts.
@devversion devversion force-pushed the build/fix-dev-infra-config branch from 153f1fc to 291425b Compare June 9, 2020 19:37
@andrewseguin andrewseguin merged commit a18753e into angular:master Jun 9, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants