refactor(datepicker): remove circular dependencies #19629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
mmalerba
reviewed
Jun 12, 2020
| export class MatDateRangePicker<D> | ||
| extends MatDatepickerBase<MatDateRangeInput<D>, DateRange<D>, D> { | ||
| export class MatDateRangePicker<D> extends | ||
| MatDatepickerBase<MatDatepickerControl<D> & {comparisonStart: D|null, comparisonEnd: D|null}, |
There was a problem hiding this comment.
Would it be good to make a common interface that MatDateRangeInput implements? That way it would enforce that the 2 classes are in agreement on the type of these additional properties
crisbeto
force-pushed
the
datepicker-circular-deps
branch
from
0cb1255 to
1ca9c47
Compare
|
@crisbeto passes presubmit, just needs rebase |
Adjusts a couple of types in order to avoid circular dependencies.
crisbeto
force-pushed
the
datepicker-circular-deps
branch
from
1ca9c47 to
9ecc318
Compare
|
Rebased. |
jelbourn
pushed a commit
that referenced
this pull request
Jun 30, 2020
Adjusts a couple of types in order to avoid circular dependencies.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts a couple of types in order to avoid circular dependencies.