Skip to content

refactor: update snippets/embedded example comments in material docs md to reflect new API (badge, toolbar) #19669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2020

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented Jun 16, 2020

Remove static code snippets in material docs and replace them with embedded examples in compact view.
Add regions in component examples.

@annieyw annieyw requested review from atscott and mmalerba June 16, 2020 21:13
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 16, 2020
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 16, 2020
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mmalerba mmalerba added the docs This issue is related to documentation label Jun 17, 2020
@mmalerba mmalerba merged commit 865d431 into angular:master Jun 17, 2020
mmalerba pushed a commit that referenced this pull request Jun 17, 2020
…md to reflect new API (badge, toolbar) (#19669)

* badge

* toolbar
@annieyw annieyw deleted the comments3 branch June 17, 2020 23:36
devversion pushed a commit to devversion/material2 that referenced this pull request Jun 18, 2020
…md to reflect new API (badge, toolbar) (angular#19669)

* badge

* toolbar
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants