docs(getting-started): specify HammerJS install instructions #1970
Conversation
googlebot
added
the
cla: yes
| @@ -46,6 +46,17 @@ Add HammerJS to your application via [npm](https://www.npmjs.com/package/hammerj | |||
| (such as the [Google CDN](https://developers.google.com/speed/libraries/#hammerjs)), or served | |||
| directly from your app. | |||
|
|
|||
| ```bash | |||
| npm install --save hammerjs @types/hammerjs | |||
There was a problem hiding this comment.
I'd prefer to see npm install --save hammerjs and npm install --save-dev @types/hammerjs
There was a problem hiding this comment.
You're right, I'll update it, thanks! 👍
Drumarcco
force-pushed
the
doc-hammerjs-instructions
branch
from
17f2ac3 to
13dd558
Compare
|
@jmcgoldrick @devversion Comment addressed 😄 |
| @@ -46,6 +46,18 @@ Add HammerJS to your application via [npm](https://www.npmjs.com/package/hammerj | |||
| (such as the [Google CDN](https://developers.google.com/speed/libraries/#hammerjs)), or served | |||
| directly from your app. | |||
|
|
|||
| ```bash | |||
There was a problem hiding this comment.
This just needs a title like "If you want to include HammerJS from npm, you can install it:"
Change GETTING_STARTED.md to include more specific HammerJS install instructions. Closes angular#1889
Drumarcco
force-pushed
the
doc-hammerjs-instructions
branch
from
13dd558 to
776cb5c
Compare
|
@jelbourn title added, but somehow the sauce labs check failed, any idea why? 🤔 |
|
SauceLabs connection is just a bit flaky. |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Change GETTING_STARTED.md to include more specific HammerJS install instructions.
Closes #1889