Skip to content

build: bazel_build CI check to also build docs-content and examples-highlighted #19719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2020
Merged

build: bazel_build CI check to also build docs-content and examples-highlighted #19719

merged 1 commit into from
Jun 26, 2020

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented Jun 22, 2020

Syntax/spelling errors when adding comments to components examples to mark out regions aren't caught until after the PR is merged.
To build examples-highlighted and docs-content on CI the docs-package tag has to be removed as build_bazel filters them out.

@annieyw annieyw requested a review from jelbourn as a code owner June 22, 2020 18:12
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 22, 2020
devversion
devversion approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should merge #19699 and then this PR.

@devversion devversion added blocked This issue is blocked by some external factor, such as a prerequisite PR lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed blocked This issue is blocked by some external factor, such as a prerequisite PR labels Jun 22, 2020
@devversion devversion added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Jun 22, 2020
mmalerba
mmalerba approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit e3cf243 into angular:master Jun 26, 2020
jelbourn pushed a commit that referenced this pull request Jun 26, 2020
@annieyw @jelbourn
build: build docs-content and examples-highlighter on PRs (#19719)
3652767 
Removes the bazel tag that filters out these builds for PRs to catch errors earlier

(cherry picked from commit e3cf243)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 27, 2020
@annieyw annieyw deleted the ci-check branch July 30, 2020 17:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba mmalerba approved these changes

@atscott atscott Awaiting requested review from atscott

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@annieyw @devversion @mmalerba @jelbourn @googlebot