Skip to content

docs(list): fix single selection example (#19723) #19731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2020
Merged

docs(list): fix single selection example (#19723) #19731

merged 1 commit into from
Jun 26, 2020

Conversation

swseverance
Copy link
Contributor

@swseverance swseverance requested a review from jelbourn as a code owner June 23, 2020 16:35
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 23, 2020
@jelbourn jelbourn requested review from andrewseguin and removed request for jelbourn June 23, 2020 18:13
crisbeto
crisbeto approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added docs This issue is related to documentation lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 24, 2020
@jelbourn jelbourn merged commit 5d50ec7 into angular:master Jun 26, 2020
jelbourn pushed a commit that referenced this pull request Jun 26, 2020
@jelbourn
docs(list): fix single selection example selection display (#19731)
c2aa77a 
The single selection example was previously rendering `[object Object]` instead of the selected value

(cherry picked from commit 5d50ec7)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs-bug(Selection lists): List with single selection example does not work properly
4 participants
@swseverance @crisbeto @jelbourn @googlebot