Skip to content

fix(material-experimental/mdc-snack-bar): support dark themes #19926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2020
Merged

fix(material-experimental/mdc-snack-bar): support dark themes #19926

merged 1 commit into from
Jul 10, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 9, 2020

Sets up the variables so that we can generate the correct colors for dark themes.

Also updates us to the latest MDC canary which has a relevant fix for mat-table.

@crisbeto
fix(material-experimental/mdc-snack-bar): support dark themes
3285143 
Sets up the variables so that we can generate the correct colors for dark themes.

Also updates us to the latest MDC canary which has a relevant fix for `mat-table`.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Jul 9, 2020
@crisbeto crisbeto requested review from andrewseguin and a team as code owners July 9, 2020 18:57
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 9, 2020
@andrewseguin andrewseguin added lgtm action: merge The PR is ready for merge by the caretaker labels Jul 9, 2020
@mmalerba mmalerba merged commit a9e0ac5 into angular:master Jul 10, 2020
mmalerba pushed a commit that referenced this pull request Jul 10, 2020
@crisbeto @mmalerba
fix(material-experimental/mdc-snack-bar): support dark themes (#19926)
9f8683a 
Sets up the variables so that we can generate the correct colors for dark themes.

Also updates us to the latest MDC canary which has a relevant fix for `mat-table`.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees

@mmalerba mmalerba

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @andrewseguin @googlebot @mmalerba