Skip to content

test(material-experimental/mdc-slider): add e2e tests #19937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2020
Merged

test(material-experimental/mdc-slider): add e2e tests #19937

merged 2 commits into from
Jul 14, 2020

Conversation

andrewseguin
Copy link
Contributor

No description provided.

@andrewseguin andrewseguin added P2 The issue is important to a large percentage of users, with a workaround merge safe target: patch This PR is targeted for the next patch release labels Jul 10, 2020
@andrewseguin andrewseguin requested a review from a team as a code owner July 10, 2020 15:36
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 10, 2020
crisbeto
crisbeto approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added lgtm action: merge The PR is ready for merge by the caretaker labels Jul 10, 2020
@mmalerba
Copy link
Contributor

@andrewseguin needs rebase, also failing CI

@andrewseguin
Copy link
Contributor Author

Rebased

@andrewseguin andrewseguin merged commit 7b789d4 into angular:master Jul 14, 2020
andrewseguin added a commit that referenced this pull request Jul 14, 2020
@andrewseguin
test(material-experimental/mdc-slider): add e2e tests (#19937)
f2211e7 
* test(material-experimental/mdc-slider): add e2e tests

* remove examples from BUILD
ngwattcos pushed a commit to ngwattcos/components that referenced this pull request Jul 20, 2020
@andrewseguin @ngwattcos
test(material-experimental/mdc-slider): add e2e tests (angular#19937)
264e88c 
* test(material-experimental/mdc-slider): add e2e tests

* remove examples from BUILD
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

@devversion devversion Awaiting requested review from devversion

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewseguin @mmalerba @crisbeto @googlebot