Skip to content

docs(readme): expand MDC point to mention benefits #20059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2020
Merged

docs(readme): expand MDC point to mention benefits #20059

merged 2 commits into from
Jul 21, 2020

Conversation

jelbourn
Copy link
Member

We mention that we're working on the MDC-based versions of the
components, but don't get into the benefits people would expect to see
from this work.

@jelbourn jelbourn added docs This issue is related to documentation merge safe target: patch This PR is targeted for the next patch release labels Jul 21, 2020
@jelbourn jelbourn requested a review from a team as a code owner July 21, 2020 18:02
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 21, 2020
@jelbourn
docs(readme): expand MDC point to mention benefits
609cfb2 
We mention that we're working on the MDC-based versions of the
components, but don't get into the benefits people would expect to see
from this work.
@jelbourn jelbourn force-pushed the readme-mdc-expanded branch from bb85fb1 to 609cfb2 Compare July 21, 2020 18:03
josephperrott
josephperrott approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

devversion
devversion approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One small nit

@jelbourn @devversion
Update README.md
6481491 
Co-authored-by: Paul Gschwendtner <[email protected]>
@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Jul 21, 2020
@wagnermaciel wagnermaciel added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jul 21, 2020
@wagnermaciel wagnermaciel merged commit bbce2de into angular:master Jul 21, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jelbourn @devversion @josephperrott @googlebot @andrewseguin @wagnermaciel