feat(material-experimental/menubar): add material menubar skeleton and dev-app #20084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy9775
requested review from
devversion,
jelbourn,
mmalerba and
a team
as code owners
googlebot
added
the
cla: yes
andy9775
force-pushed
the
mat-experimental-menubar-skeleton
branch
from
71d8fce to
d98f9e7
Compare
jelbourn
approved these changes
Jul 24, 2020
jelbourn
added
lgtm
action: merge
|
New rule: Skeleton PRs only 😆 |
devversion
approved these changes
Jul 25, 2020
|
|
||
| /** | ||
| * A material design MenubarItem adhering to the functionality of CdkMenuItem and | ||
| * CdkMenuItemTrigger. It's main purpose is to trigger menus and it lives inside of |
There was a problem hiding this comment.
Nit: Should this be its ?
Suggested change
| * CdkMenuItemTrigger. It's main purpose is to trigger menus and it lives inside of | |
| * CdkMenuItemTrigger. Its main purpose is to trigger menus and it lives inside of |
…d dev-app Add the material-experimental/menubar component skeletons and the accompanying dev app and its configuration.
andy9775
force-pushed
the
mat-experimental-menubar-skeleton
branch
from
d98f9e7 to
ab538c3
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the material-experimental/menubar component skeletons and the accompanying dev app
and its configuration.