fix,perf(column-resize): Coalesce style updates along with sticky styler #20086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kseamon
changed the title
kseamon
changed the title
kseamon
force-pushed
the
table-coalesce-measurements-also-resize
branch
from
bd05991 to
23569ea
Compare
jelbourn
added
G
jelbourn
approved these changes
Jul 28, 2020
There was a problem hiding this comment.
LGTM, just a couple nits
Also want @andrewseguin to take a look
jelbourn
added
lgtm
merge: fix commit message
andrewseguin
approved these changes
Jul 31, 2020
andrewseguin
added
action: merge
kseamon
force-pushed
the
table-coalesce-measurements-also-resize
branch
from
b74e9b3 to
39c1d99
Compare
kseamon
force-pushed
the
table-coalesce-measurements-also-resize
branch
from
39c1d99 to
db08c35
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coalesces style updates triggered by the column resize system to trigger less layout thrashing. Also updates sticky column styles when resizing a column.
The net effect is a substantial improvement when applying min/max sizes at startup and a bit of a wash when actively resizing. The gains in active resize performance are mostly offset by the additional cost of recomputing sticky styles (but it was a bug before that they were not being recomputed). Should be much better for tables without sticky columns though.