Skip to content

docs(tree): fix typo in tree template #20231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2020
Merged

docs(tree): fix typo in tree template #20231

merged 1 commit into from
Aug 12, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 7, 2020

A bunch of tree examples were copied off of each other and were referecing a non-existent property which resulted in an incorrect aria-label.

Fixes #20216.

@crisbeto
docs(tree): fix typo in tree template
ff808c9 
A bunch of tree examples were copied off of each other and were referecing a non-existent property which resulted in an incorrect `aria-label`.

Fixes angular#20216.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent docs This issue is related to documentation merge safe target: patch This PR is targeted for the next patch release labels Aug 7, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 7, 2020
jelbourn
jelbourn approved these changes Aug 7, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Aug 7, 2020
@andrewseguin andrewseguin merged commit c79dc6f into angular:master Aug 12, 2020
andrewseguin pushed a commit that referenced this pull request Aug 12, 2020
@crisbeto @andrewseguin
docs(tree): fix typo in tree template (#20231)
548f8ae 
A bunch of tree examples were copied off of each other and were referecing a non-existent property which resulted in an incorrect `aria-label`.

Fixes #20216.

(cherry picked from commit c79dc6f)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@devversion devversion Awaiting requested review from devversion

Assignees

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Material Tree checklist example - Mistake in node property
5 participants
@crisbeto @jelbourn @devversion @googlebot @andrewseguin