Skip to content

perf(column-resize): Further defer initial min/max column size applic… #20238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2020
Merged

perf(column-resize): Further defer initial min/max column size applic… #20238

merged 1 commit into from
Aug 12, 2020

Conversation

kseamon
Copy link
Collaborator

@kseamon kseamon commented Aug 7, 2020

…ation to reduce layout thrashing

@kseamon kseamon requested a review from andrewseguin as a code owner August 7, 2020 17:58
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 7, 2020
@kseamon kseamon requested a review from jelbourn August 7, 2020 17:59
jelbourn
jelbourn approved these changes Aug 7, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Aug 7, 2020
@jelbourn
Copy link
Member

jelbourn commented Aug 7, 2020

Caretaker note: marked as merge safe since only Karl's project is using this internally

@andrewseguin andrewseguin merged commit 3ce4452 into angular:master Aug 12, 2020
andrewseguin pushed a commit that referenced this pull request Aug 12, 2020
@kseamon @andrewseguin
perf(column-resize): Further defer initial min/max column size applic…
42d3fd0 
…ation to reduce layout thrashing (#20238)

(cherry picked from commit 3ce4452)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kseamon @jelbourn @googlebot @andrewseguin