build: enforce consistent readonly array type #20290
Conversation
googlebot
added
the
cla: yes
rafaelss95
force-pushed
the
build/enforce-unique-readonly-array
branch
from
1c6bbcd to
7275a3f
Compare
rafaelss95
requested review from
andrewseguin,
crisbeto,
devversion,
jelbourn and
a team
as code owners
| @@ -7,7 +7,7 @@ | |||
| */ | |||
|
|
|||
| import {ViewportRuler} from '@angular/cdk/scrolling'; | |||
| import {getMutableClientRect, adjustClientRect} from './client-rect'; | |||
| import {adjustClientRect, getMutableClientRect} from './client-rect'; | |||
There was a problem hiding this comment.
Note that reordering the imports will make it harder to land and will cause conflicts with existing PRs.
There was a problem hiding this comment.
Note that reordering the imports will make it harder to land and will cause conflicts with existing PRs.
That's my IDE config configuration, it always sorts it alphabetically :)
Anyway, if it causes too much noise, I can disable this configuration and rollback it.
There was a problem hiding this comment.
It might be best to roll it back since it causes a lot of churn for existing PRs.
There was a problem hiding this comment.
LGTM, marking as major out of an abundance of caution, I'd also like @andrewseguin to take a look
rafaelss95
force-pushed
the
build/enforce-unique-readonly-array
branch
3 times, most recently
from
efde4ef to
af70d96
Compare
rafaelss95
force-pushed
the
build/enforce-unique-readonly-array
branch
from
af70d96 to
3a8e5f7
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Relates to:
This PR brings normalization on the form of write readonly arrays:
readonly TYPE [].Note that for some cases, specifically truly constants, I've opted out to use
as constas it's shorter and fully immutable without the need of declaring the type.