Skip to content

build(google-maps): add server-side rendering checks for new layers #20386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2020
Merged

build(google-maps): add server-side rendering checks for new layers #20386

merged 1 commit into from
Aug 28, 2020

Conversation

crisbeto
Copy link
Member

A few new layer components were added to the google-maps module. These changes add them to the SSR kitchen sink.

@crisbeto
build(google-maps): add server-side rendering checks for new layers
054c1fc 
A few new layer components were added to the `google-maps` module. These changes add them to the SSR kitchen sink.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Aug 21, 2020
@crisbeto crisbeto requested a review from devversion as a code owner August 21, 2020 20:41
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 21, 2020
@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Aug 24, 2020
@jelbourn jelbourn added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Aug 28, 2020
@jelbourn jelbourn merged commit eb17f37 into angular:master Aug 28, 2020
annieyw pushed a commit to annieyw/components that referenced this pull request Aug 31, 2020
@crisbeto @annieyw
build(google-maps): add server-side rendering checks for new layers (a…
db4644b 
…ngular#20386)

A few new layer components were added to the `google-maps` module. These changes add them to the SSR kitchen sink.
mmalerba pushed a commit to mmalerba/components that referenced this pull request Sep 5, 2020
@crisbeto @mmalerba
build(google-maps): add server-side rendering checks for new layers (a…
9d71d17 
…ngular#20386)

A few new layer components were added to the `google-maps` module. These changes add them to the SSR kitchen sink.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @devversion @jelbourn @googlebot