test: reduce reliance on static queries #20405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
crisbeto
requested review from
andrewseguin,
jelbourn and
mmalerba
as code owners
googlebot
added
the
cla: yes
|
most of them look fine, but there's a failing table test |
When Ivy issues were first being resolved in the repo, we accumulated a lot of static queries in tests which we generally shouldn't be depending on. These changes clean up most of the ones that don't require much refactoring to clean up. I'll make some follow-up changes for the trickier ones once these changes land.
crisbeto
force-pushed
the
static-query-cleanup
branch
from
f17acbd to
1d79537
Compare
|
I just reverted the table change that was causing the failure. I'll do follow-up PRs to address these trickier cases. |
jelbourn
pushed a commit
that referenced
this pull request
Aug 28, 2020
When Ivy issues were first being resolved in the repo, we accumulated a lot of static queries in tests which we generally shouldn't be depending on. These changes clean up most of the ones that don't require much refactoring to clean up. I'll make some follow-up changes for the trickier ones once these changes land. (cherry picked from commit 169ebc4)
annieyw
pushed a commit
to annieyw/components
that referenced
this pull request
Aug 31, 2020
When Ivy issues were first being resolved in the repo, we accumulated a lot of static queries in tests which we generally shouldn't be depending on. These changes clean up most of the ones that don't require much refactoring to clean up. I'll make some follow-up changes for the trickier ones once these changes land.
mmalerba
pushed a commit
that referenced
this pull request
Sep 2, 2020
When Ivy issues were first being resolved in the repo, we accumulated a lot of static queries in tests which we generally shouldn't be depending on. These changes clean up most of the ones that don't require much refactoring to clean up. I'll make some follow-up changes for the trickier ones once these changes land.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Ivy issues were first being resolved in the repo, we accumulated a lot of static queries in tests which we generally shouldn't be depending on. These changes clean up most of the ones that don't require much refactoring to clean up. I'll make some follow-up changes for the trickier ones once these changes land.