fix(cdk-experimental/combobox): not cleaning up overlay on destroy #20407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The combobox was leaving behind its open overlays when it gets destroyed, because it wasn't calling `OverlayRef.dispose`.
crisbeto
added
P3
googlebot
added
the
cla: yes
jelbourn
reviewed
Aug 25, 2020
Comment on lines
+117
to
+119
| if (this._overlayRef) { | ||
| this._overlayRef.dispose(); | ||
| } |
There was a problem hiding this comment.
optional:
Suggested change
| if (this._overlayRef) { | |
| this._overlayRef.dispose(); | |
| } | |
| this._overlayRef?.dispose(); |
jelbourn
added
action: merge
annieyw
pushed a commit
to annieyw/components
that referenced
this pull request
Aug 31, 2020
…ngular#20407) The combobox was leaving behind its open overlays when it gets destroyed, because it wasn't calling `OverlayRef.dispose`.
mmalerba
pushed a commit
to mmalerba/components
that referenced
this pull request
Sep 5, 2020
…ngular#20407) The combobox was leaving behind its open overlays when it gets destroyed, because it wasn't calling `OverlayRef.dispose`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The combobox was leaving behind its open overlays when it gets destroyed, because it wasn't calling
OverlayRef.dispose.