test(mdc-tabs): add performance tests for mdc-tabs #20496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
reviewed
Sep 7, 2020
devversion
added
merge safe
target: patch
crisbeto
reviewed
Sep 7, 2020
devversion
approved these changes
Sep 8, 2020
test/benchmarks/mdc/tabs/BUILD.bazel
Outdated
| ], | ||
| ng_srcs = [ | ||
| ":app.module.ts", | ||
| ":fake-tab-data.ts", |
There was a problem hiding this comment.
Just a FYI: The usual convention is that colon is only used for Bazel target. Plain input files are without the colon.
andrewseguin
pushed a commit
that referenced
this pull request
Sep 11, 2020
* test(mdc-tabs): add performance tests for mdc-tabs * use template string to format fake tab data correctly * fix indentation and remove unnecessary providers * fix selectors for mdc tabs benchmark * remove ':' from source files (cherry picked from commit e13a79d)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.