Skip to content

fix(icon): not updating svg icon assigned through setter #20509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2020
Merged

fix(icon): not updating svg icon assigned through setter #20509

merged 1 commit into from
Oct 28, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 7, 2020

Moves some logic around so the icon can respond to changes in its state through plain property assignments, rather than going through Angular change detection cycle. This makes the component easier to extend.

Fixes #20470.

@crisbeto
fix(icon): not updating svg icon assigned through setter
c7652e7 
Moves some logic around so the icon can respond to changes in its state through plain property assignments, rather than going through Angular change detection cycle. This makes the component easier to extend.

Fixes angular#20470.
@crisbeto crisbeto added P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels Sep 7, 2020
@crisbeto crisbeto requested a review from jelbourn as a code owner September 7, 2020 19:41
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 7, 2020
@crisbeto crisbeto mentioned this pull request Sep 7, 2020
Closed
jelbourn
jelbourn approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Sep 17, 2020
@wagnermaciel wagnermaciel merged commit 4263cac into angular:master Oct 28, 2020
wagnermaciel pushed a commit that referenced this pull request Oct 28, 2020
@crisbeto @wagnermaciel
fix(icon): not updating svg icon assigned through setter (#20509)
9f73933 
Moves some logic around so the icon can respond to changes in its state through plain property assignments, rather than going through Angular change detection cycle. This makes the component easier to extend.

Fixes #20470.

(cherry picked from commit 4263cac)
wagnermaciel pushed a commit that referenced this pull request Oct 28, 2020
@crisbeto @wagnermaciel
fix(icon): not updating svg icon assigned through setter (#20509)
6b13154 
Moves some logic around so the icon can respond to changes in its state through plain property assignments, rather than going through Angular change detection cycle. This makes the component easier to extend.

Fixes #20470.

(cherry picked from commit 4263cac)
@crisbeto crisbeto mentioned this pull request Nov 12, 2020
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrianboscanean andrianboscanean andrianboscanean approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(icon): custom directive cannot set svgIcon for mat-icon
5 participants
@crisbeto @jelbourn @andrianboscanean @googlebot @wagnermaciel