Skip to content

test(mat-table-benchmark): correct html file name #20513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2020
Merged

test(mat-table-benchmark): correct html file name #20513

merged 1 commit into from
Sep 11, 2020

Conversation

wagnermaciel
Copy link
Contributor

No description provided.

@wagnermaciel wagnermaciel requested a review from a team as a code owner September 8, 2020 19:05
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 8, 2020
devversion
devversion approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The commit message should be updated to not use fix but test

@devversion devversion added the merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed label Sep 8, 2020
@wagnermaciel wagnermaciel added action: merge The PR is ready for merge by the caretaker merge safe and removed merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Sep 8, 2020
@devversion devversion changed the title fix(mat-table-benchmark): correct html file name test(mat-table-benchmark): correct html file name Sep 8, 2020
@wagnermaciel wagnermaciel added the target: patch This PR is targeted for the next patch release label Sep 8, 2020
@andrewseguin andrewseguin merged commit e75c4e6 into angular:master Sep 11, 2020
andrewseguin pushed a commit that referenced this pull request Sep 11, 2020
@wagnermaciel @andrewseguin
test(mat-table-benchmark): correct html file name (#20513)
947ffe8 
(cherry picked from commit e75c4e6)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 12, 2020
@wagnermaciel wagnermaciel deleted the fix-table-benchmark branch January 14, 2021 19:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wagnermaciel @devversion @josephperrott @googlebot @andrewseguin