Skip to content

feat(material-experimental/mdc-select): add test harness #20603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2020
Merged

feat(material-experimental/mdc-select): add test harness #20603

merged 1 commit into from
Sep 22, 2020

Conversation

crisbeto
Copy link
Member

Adds a test harness for the MDC-based mat-select.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround merge safe G This is is related to a Google internal issue target: minor This PR is targeted for the next minor release labels Sep 18, 2020
@crisbeto crisbeto requested a review from jelbourn as a code owner September 18, 2020 18:52
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 18, 2020
@crisbeto crisbeto changed the title feat(material-experimenta/mdc-select): add test harness feat(material-experimental/mdc-select): add test harness Sep 18, 2020
@crisbeto
feat(material-experimental/mdc-select): add test harness
6441810 
Adds a test harness for the MDC-based `mat-select`.
jelbourn
jelbourn approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Sep 18, 2020
@crisbeto crisbeto mentioned this pull request Sep 20, 2020
Merged
@annieyw annieyw merged commit 29e1f26 into angular:master Sep 22, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@mmalerba mmalerba

@annieyw annieyw

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @jelbourn @googlebot @mmalerba @annieyw