Skip to content

fix(material-experimental/mdc-form-field): not adding mat-primary theme class #20605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2020
Merged

fix(material-experimental/mdc-form-field): not adding mat-primary theme class #20605

merged 1 commit into from
Sep 22, 2020

Conversation

crisbeto
Copy link
Member

The MDC-based form field doesn't add the mat-primary class if the color isn't accent or warn, because it doesn't go through the color mixin.

@crisbeto
fix(material-experimental/mdc-form-field): not adding mat-primary the…
481db5c 
…me class

The MDC-based form field doesn't add the `mat-primary` class if the color isn't `accent`
or `warn`, because it doesn't go through the `color` mixin.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: minor This PR is targeted for the next minor release labels Sep 19, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 19, 2020
devversion
devversion approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great that we have tests for it now!

I intentionally didn't add the class initially as the default MDC styles are already primary, but it makes sense as
those classes are needed for custom controls.

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Sep 21, 2020
@annieyw annieyw merged commit d8def8b into angular:master Sep 22, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@devversion devversion

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @devversion @googlebot @mmalerba @annieyw