feat(material-experimental/mdc-paginator): implement MDC-based paginator #20607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
added
G
crisbeto
requested review from
andrewseguin,
devversion,
jelbourn,
mmalerba and
a team
as code owners
crisbeto
commented
Sep 20, 2020
| export declare function MAT_PAGINATOR_INTL_PROVIDER_FACTORY(parentIntl: MatPaginatorIntl): MatPaginatorIntl; | ||
|
|
||
| export declare class MatPaginator extends _MatPaginatorBase implements OnInit, OnDestroy, CanDisable, HasInitialized { | ||
| export declare abstract class _MatPaginatorBase<O extends { |
There was a problem hiding this comment.
These API changes are because I moved the logic into a base class.
Implements `mat-paginator` on top of MDC Web and the logic from the existing paginator. The structural styles are close to what we have in the current paginator, while the theming and typography are implemented on top of MDC's mixins. Furthermore, we're using the MDC versions of `mat-select` and `mat-button` inside the paginator. There are the following gotchas in this implementation: 1. The `mat-form-field` inside the paginator is set to always use the densest layout possible. This is necessary, because the MDC form field is too tall by default. 2. We hide one internal element from the form field, because it throws off the vertical alignment and is only used for hints and error messages which the paginator doesn't have. 3. I had to duplicate the `MatPaginatorDefaultOptions` interface, because the appearance of the MDC form field doesn't support the `legacy` and `standard` values.
crisbeto
force-pushed
the
mdc-paginator
branch
from
71bf5a9 to
a484b85
Compare
jelbourn
added
action: merge
|
Caretaker note: this isn't merge-safe since it touched the all-theme and thus needs a build file update before triggering presubmit |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
mat-paginatoron top of MDC Web and the logic from the existing paginator. The structural styles are close to what we have in the current paginator, while the theming and typography are implemented on top of MDC's mixins. Furthermore, we're using the MDC versions ofmat-selectandmat-buttoninside the paginator.There are the following gotchas in this implementation:
mat-form-fieldinside the paginator is set to always use the densest layout possible. This is necessary, because the MDC form field is too tall by default.MatPaginatorDefaultOptionsinterface, because the appearance of the MDC form field doesn't support thelegacyandstandardvalues.Note: doesn't include a test harness, because it depends on #20603. I'll make a follow-up PR to add it.