Skip to content

build: update tslint rules to remove usage of whitelist in comments #20618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2020
Merged

build: update tslint rules to remove usage of whitelist in comments #20618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tools/tslint-rules/validateDecoratorsRule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@ import * as minimatch from 'minimatch';

/**
* Rule that enforces certain decorator properties to be defined and to match a pattern.
* Properties can be forbidden by prefixing their name with a `!`. Supports whitelisting
* files via the third argument, as well as validating all the arguments by passing in a regex. E.g.
* Properties can be forbidden by prefixing their name with a `!`. Supports specifying a matcher for
* filtering valid files via the third argument, as well as validating all the arguments by passing
Comment on lines +8 to +9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Properties can be forbidden by prefixing their name with a `!`. Supports specifying a matcher for
* filtering valid files via the third argument, as well as validating all the arguments by passing
* Properties can be forbidden by prefixing their name with a `!`. Supports an allow list for
* filtering valid files via the third argument, as well as validating all the arguments by passing

Just an optional nit comment for it being more accurate. A matcher (subjectively) implies a function/predicate to me.

* in a regex. E.g.
*
* ```
* "validate-decorators": [true, {
Expand Down