Skip to content

build: update the commit messages in the stage-release script #20622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2020
Merged

build: update the commit messages in the stage-release script #20622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33a02a7
build: update the commit messages in the stage-release script
wagnermaciel Sep 21, 2020
b511597
build: update the commit message check in the publish script
wagnermaciel Sep 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/release/publish-release.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ class PublishReleaseTask extends BaseReleaseTask {
* through the release staging script.
*/
private _verifyLastCommitFromStagingScript() {
if (!/chore: (bump version|update changelog for)/.test(this.git.getCommitTitle('HEAD'))) {
if (!/release: (bump version|update changelog for)/.test(this.git.getCommitTitle('HEAD'))) {
console.error(chalk.red(` ✘ The latest commit of the current branch does not seem to be ` +
` created by the release staging script.`));
console.error(chalk.red(` Please stage the release using the staging script.`));
Expand Down
4 changes: 2 additions & 2 deletions tools/release/stage-release.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,9 @@ class StageReleaseTask extends BaseReleaseTask {
// Note: When updating the commit messages here. Please also update the
// release publish script to detect the new commit messages.
if (needsVersionBump) {
this.git.createNewCommit(`chore: bump version to ${newVersionName} w/ changelog`);
this.git.createNewCommit(`release: bump version to ${newVersionName} w/ changelog`);
} else {
this.git.createNewCommit(`chore: update changelog for ${newVersionName}`);
this.git.createNewCommit(`release: update changelog for ${newVersionName}`);
}

console.info();
Expand Down