Skip to content

fix(material-experimental/mdc-form-field): implement new methods added to text field adapter #20739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2020

Conversation

wagnermaciel
Copy link
Contributor

Project import generated by Copybara.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Oct 6, 2020
@mmalerba mmalerba changed the title Project import generated by Copybara. fix(material-experimental/mdc-form-field): implement new methods added to text field adapter Oct 6, 2020
@allan-chen
Copy link

This should be submittable now since MDC PR has been merged. Thanks for creating this PR!

@wagnermaciel wagnermaciel requested a review from a team as a code owner October 12, 2020 18:01
@wagnermaciel wagnermaciel added target: patch This PR is targeted for the next patch release cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Oct 12, 2020
@google-cla
Copy link

google-cla bot commented Oct 12, 2020

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Oct 13, 2020
@wagnermaciel wagnermaciel added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 13, 2020
@google-cla
Copy link

google-cla bot commented Oct 13, 2020

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@wagnermaciel wagnermaciel removed the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Oct 13, 2020
@google-cla google-cla bot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Oct 14, 2020
@wagnermaciel wagnermaciel added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Oct 14, 2020
@google-cla
Copy link

google-cla bot commented Oct 14, 2020

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@wagnermaciel wagnermaciel added the action: merge The PR is ready for merge by the caretaker label Oct 14, 2020
@wagnermaciel wagnermaciel added merge safe target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Oct 14, 2020
@wagnermaciel wagnermaciel merged commit c3aa76e into master Oct 14, 2020
@Splaktar Splaktar deleted the _cl_out_335453885 branch October 26, 2020 17:36
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants