Skip to content

docs: fix link in DEV_ENVIRONMENT guide #20773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2020
Merged

docs: fix link in DEV_ENVIRONMENT guide #20773

merged 1 commit into from
Dec 14, 2020

Conversation

bampakoa
Copy link
Contributor

Fix link for installing MSYS2 in the Developer guide

@bampakoa bampakoa requested a review from a team as a code owner October 13, 2020 07:30
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 13, 2020
@bampakoa
Copy link
Contributor Author

I am trying to submit this PR but the lint rule of the CI fails because chore is not in the list of available TYPES, although it is included as a valid type in the CONTRIBUTING guide . I would appreciate any help on that 🙏

crisbeto
crisbeto approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM. Regarding the lint failure, you could change it to docs, although I'm not completely sure that it won't require a scope.

@bampakoa @josephperrott
docs: fix link in DEV_ENVIRONMENT guide
440b31f 
Fix link for installing MSYS2 in the Developer guide
@josephperrott josephperrott changed the title chore: Fix link in DEV_ENVIRONMENT guide docs: fix link in DEV_ENVIRONMENT guide Nov 12, 2020
josephperrott
josephperrott approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Dec 9, 2020
@mmalerba mmalerba merged commit 272c1a3 into angular:master Dec 14, 2020
mmalerba pushed a commit that referenced this pull request Dec 14, 2020
@bampakoa @mmalerba
docs: fix link in DEV_ENVIRONMENT guide (#20773)
4af4477 
Fix link for installing MSYS2 in the Developer guide

(cherry picked from commit 272c1a3)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 14, 2021
@bampakoa bampakoa deleted the dev-docs branch May 19, 2021 21:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bampakoa @crisbeto @josephperrott @mmalerba