fix(cdk/drag-drop): error when cloning file input with value #20793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we clone the dragged element to generate its preview, we transfer the values of inputs so that they look identical. The problem is that assigning the value of a `file` input will throw an error so we have to skip it. **Note:** does not include a unit test, because we can't set the of a test element programmatically. Fixes angular#20783.
crisbeto
added
P2
google-cla
bot
added
the
cla: yes
annieyw
approved these changes
Oct 14, 2020
annieyw
pushed a commit
that referenced
this pull request
Oct 16, 2020
When we clone the dragged element to generate its preview, we transfer the values of inputs so that they look identical. The problem is that assigning the value of a `file` input will throw an error so we have to skip it. **Note:** does not include a unit test, because we can't set the of a test element programmatically. Fixes #20783. (cherry picked from commit 5eb1035)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we clone the dragged element to generate its preview, we transfer the values of inputs so that they look identical. The problem is that assigning the value of a
fileinput will throw an error so we have to skip it.Note: does not include a unit test, because we can't set the of a test element programmatically.
Fixes #20783.