Skip to content

refactor(material/core): remove usages of deprecated Sass functions #20811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

crisbeto
Copy link
Member

We had a bunch of places using the deprecated variants of functions like map_get, map_has_key and map_merge. These changes migrate to the non-deprecated variants.

These changes are also necessary in order for the sass-migrator script to migrate the function calls.

We had a bunch of places using the deprecated variants of functions like `map_get`,
`map_has_key` and `map_merge`. These changes migrate to the non-deprecated variants.

These changes are also necessary in order for the `sass-migrator` script to migrate
the function calls.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround merge safe target: patch This PR is targeted for the next patch release labels Oct 15, 2020
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 15, 2020
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker and removed merge safe labels Oct 19, 2020
@jelbourn jelbourn merged commit 63a8ff5 into angular:master Oct 20, 2020
jelbourn pushed a commit that referenced this pull request Oct 20, 2020
…20811)

We had a bunch of places using the deprecated variants of functions like `map_get`,
`map_has_key` and `map_merge`. These changes migrate to the non-deprecated variants.

These changes are also necessary in order for the `sass-migrator` script to migrate
the function calls.

(cherry picked from commit 63a8ff5)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants