build: drop typescript 3.9 checks #20827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
crisbeto
requested review from
devversion,
jelbourn and
a team
as code owners
google-cla
bot
added
the
cla: yes
jelbourn
approved these changes
Oct 19, 2020
jelbourn
added
the
blocked
crisbeto
added
action: merge
|
Unblocking since the Framework PR has landed. |
crisbeto
force-pushed
the
ts-3.9-removal
branch
from
ebbf960 to
916b6df
Compare
|
@crisbeto I don't think we can remove the tests until Google is off 3.9 |
|
The Framework team dropped support on their end though. See angular/angular#39313. |
|
They changed the supported TS range for CLI apps, but they still have the tests for it (Andrew's PR says those will be removed in a follow-up, and that follow up would also be blocked on Google finishing updating to 4.0) |
crisbeto
added
blocked
|
Alright, re-blocking this one. |
josephperrott
force-pushed
the
ts-3.9-removal
branch
from
916b6df to
c18908d
Compare
josephperrott
removed
the
blocked
|
@crisbeto is this merge ready again? |
|
Looks like support was dropped in v11 from the Framework repo. Unblocking. |
mmalerba
added
target: minor
Removes the TypeScript 3.9 checks since the framework is in the process of removing support (see angular/angular#39313). Also updates the Firebase functions to TS 4.0.
crisbeto
force-pushed
the
ts-3.9-removal
branch
from
c18908d to
7dfa40d
Compare
mmalerba
added
target: patch
mmalerba
pushed a commit
that referenced
this pull request
Nov 13, 2020
Removes the TypeScript 3.9 checks since the framework is in the process of removing support (see angular/angular#39313). Also updates the Firebase functions to TS 4.0. (cherry picked from commit ab8ec83)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the TypeScript 3.9 checks since the framework is in the process of removing support (see angular/angular#39313).
Also updates the Firebase functions to TS 4.0.
Note: this is merge-safe since it only changes build-related code.