Skip to content

docs(material/autocomplete): add autocomplete harness example #20830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2020
Merged

docs(material/autocomplete): add autocomplete harness example #20830

merged 1 commit into from
Oct 28, 2020

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented Oct 19, 2020

No description provided.

@annieyw annieyw requested a review from andrewseguin as a code owner October 19, 2020 19:51
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 19, 2020
@annieyw annieyw force-pushed the autocomplete-harness-example branch 3 times, most recently from 13f89a1 to 846690c Compare October 19, 2020 20:55
@annieyw annieyw force-pushed the autocomplete-harness-example branch 2 times, most recently from 9225df7 to 402f4d6 Compare October 19, 2020 23:58
@annieyw annieyw added docs This issue is related to documentation merge safe P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Oct 20, 2020
@annieyw annieyw force-pushed the autocomplete-harness-example branch from 402f4d6 to 70f298c Compare October 20, 2020 19:05
jelbourn
jelbourn approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jelbourn
jelbourn approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lint is failing because the commit message body has a long line

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Oct 20, 2020
@annieyw annieyw force-pushed the autocomplete-harness-example branch from 70f298c to 827f6c4 Compare October 26, 2020 16:40
@wagnermaciel wagnermaciel merged commit e2ebfe0 into angular:master Oct 28, 2020
wagnermaciel pushed a commit that referenced this pull request Oct 28, 2020
@annieyw @wagnermaciel
docs(material/autocomplete): add autocomplete harness example (#20830)
66a770c 
(cherry picked from commit e2ebfe0)
wagnermaciel pushed a commit that referenced this pull request Oct 28, 2020
@annieyw @wagnermaciel
docs(material/autocomplete): add autocomplete harness example (#20830)
4fc4aa6 
(cherry picked from commit e2ebfe0)
@annieyw annieyw deleted the autocomplete-harness-example branch November 9, 2020 19:41
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@wagnermaciel wagnermaciel Awaiting requested review from wagnermaciel

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annieyw @jelbourn @wagnermaciel