Skip to content

docs(material/dialog): fix typo in animation description #20886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Oct 28, 2020
Merged

docs(material/dialog): fix typo in animation description #20886

merged 1 commit into from Oct 28, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 26, 2020

Fixes a typo in the description of dialog container animations file.

@ghost ghost requested review from crisbeto and jelbourn as code owners October 26, 2020 17:18
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 26, 2020
@crisbeto
Copy link
Member

The change looks good, but the commit message needs to be changed to something like docs(material/dialog): fix typo in animation description in order to pass the formatting check.

@ghost ghost changed the title Typo: dialog-animations.ts docs(material/dialog): fix typo in animation description Oct 26, 2020
@ghost
Copy link
Author

ghost commented Oct 26, 2020

The change looks good, but the commit message needs to be changed to something like docs(material/dialog): fix typo in animation description in order to pass the formatting check.

Done.

@crisbeto
Copy link
Member

Your change only renamed the pull request. In order for the lint check to pass, the commit message itself needs to be changed.

Fixes a typo in the description of dialog container animations file.
@crisbeto crisbeto added docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Oct 26, 2020
@ghost
Copy link
Author

ghost commented Oct 27, 2020

@jelbourn

@wagnermaciel wagnermaciel merged commit ec252f8 into angular:master Oct 28, 2020
wagnermaciel pushed a commit that referenced this pull request Oct 28, 2020
Fixes a typo in the description of dialog container animations file.

(cherry picked from commit ec252f8)
wagnermaciel pushed a commit that referenced this pull request Oct 28, 2020
Fixes a typo in the description of dialog container animations file.

(cherry picked from commit ec252f8)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants