Skip to content

fix(material-experimental/mdc-checkbox): fix dark theme #20926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2020
Merged

fix(material-experimental/mdc-checkbox): fix dark theme #20926

merged 1 commit into from
Oct 30, 2020

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba requested a review from jelbourn October 29, 2020 22:43
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 29, 2020
jelbourn
jelbourn approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Oct 29, 2020
@jelbourn
Copy link
Member

Caretaker note: this will probably, at the very least, break our own internal screenshot tests

@mmalerba mmalerba added the P2 The issue is important to a large percentage of users, with a workaround label Oct 29, 2020
@wagnermaciel wagnermaciel merged commit 9b3992b into angular:master Oct 30, 2020
wagnermaciel pushed a commit that referenced this pull request Oct 30, 2020
@mmalerba @wagnermaciel
fix(material-experimental/mdc-checkbox): fix dark theme (#20926)
e8d566a 
(cherry picked from commit 9b3992b)
wagnermaciel pushed a commit that referenced this pull request Oct 30, 2020
@mmalerba @wagnermaciel
fix(material-experimental/mdc-checkbox): fix dark theme (#20926)
d018d48 
(cherry picked from commit 9b3992b)
wagnermaciel added a commit that referenced this pull request Oct 30, 2020
@wagnermaciel
Revert "fix(material-experimental/mdc-checkbox): fix dark theme (#20926…
a349275 
…)"

This reverts commit 9b3992b.
wagnermaciel added a commit that referenced this pull request Oct 30, 2020
@wagnermaciel
Revert "fix(material-experimental/mdc-checkbox): fix dark theme (#20926…
07f6a48 
…)" (#20939)

This reverts commit 9b3992b.
wagnermaciel added a commit that referenced this pull request Oct 30, 2020
@wagnermaciel
Revert "fix(material-experimental/mdc-checkbox): fix dark theme (#20926…
9011039 
…)" (#20939)

This reverts commit 9b3992b.

(cherry picked from commit 07f6a48)
wagnermaciel added a commit that referenced this pull request Oct 30, 2020
@wagnermaciel
Revert "fix(material-experimental/mdc-checkbox): fix dark theme (#20926…
0fa0b45 
…)" (#20939)

This reverts commit 9b3992b.

(cherry picked from commit 07f6a48)
@mmalerba mmalerba mentioned this pull request Oct 30, 2020
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmalerba @jelbourn @wagnermaciel