Skip to content

Correctly show the correct position option #2099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

chrishawn
Copy link

Correctly show the correct position option in the example

Correctly show the correct position option in the example
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Dec 7, 2016
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, looks good. Make googlebot happy and we can get this one in

@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 7, 2016
@belev
Copy link
Contributor

belev commented Dec 7, 2016

@andrewseguin added the labels that it is ready for merge, but isn't it better before that to change the commit message according to the Commit Message Guidelines ?

@andrewseguin andrewseguin removed the action: merge The PR is ready for merge by the caretaker label Dec 8, 2016
@andrewseguin
Copy link
Contributor

Commit message is changed when we merge, but removed the label for the sake of the cla:no

@andrewseguin
Copy link
Contributor

Made the change in #2104. Thanks for pointing out the typo

@chrishawn
Copy link
Author

Tried to fill out CLA page was broken didn't allow me to submit kept saying I was missing data when I wasn't

@belev
Copy link
Contributor

belev commented Dec 8, 2016

@andrewseguin ah, ok. Thanks for clarifying!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants