-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Correctly show the correct position option #2099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Correctly show the correct position option in the example
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this, looks good. Make googlebot happy and we can get this one in
@andrewseguin added the labels that it is ready for merge, but isn't it better before that to change the commit message according to the Commit Message Guidelines ? |
Commit message is changed when we merge, but removed the label for the sake of the cla:no |
Made the change in #2104. Thanks for pointing out the typo |
Tried to fill out CLA page was broken didn't allow me to submit kept saying I was missing data when I wasn't |
@andrewseguin ah, ok. Thanks for clarifying! |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Correctly show the correct position option in the example