refactor(material/datepicker): expose month view change detector ref #21048
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
MichaelJamesParsons
added
area: material/datepicker
G
crisbeto
reviewed
Nov 15, 2020
| @@ -180,7 +180,7 @@ export class MatMonthView<D> implements AfterContentInit, OnChanges, OnDestroy { | |||
| /** The names of the weekdays. */ | |||
| _weekdays: {long: string, narrow: string}[]; | |||
|
|
|||
| constructor(private _changeDetectorRef: ChangeDetectorRef, | |||
| constructor(readonly _changeDetectorRef: ChangeDetectorRef, | |||
There was a problem hiding this comment.
The change is fine, but what's the context behind it? Which other components need to access it?
There was a problem hiding this comment.
There's a Google internal datepicker spec based off this one. It's needed as part of implementing that.
wagnermaciel
added
the
target: patch
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the datepicker month view's
ChangeDetectorRefas part of its public (internal) API so it can be accessed by other components.