Skip to content

docs: fix form field example styles #21124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

crisbeto
Copy link
Member

  • Fixes an example that was referring to the example-container class, but wasn't actually using it.
  • Uses flexbox to layout the example, instead of br tags which are an anti-pattern.

Fixes angular/material.angular.io#889.

@crisbeto crisbeto added docs This issue is related to documentation merge safe P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels Nov 23, 2020
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 23, 2020
* Fixes an example that was referring to the `example-container` class, but wasn't actually using it.
* Uses flexbox to layout the example, instead of `br` tags which are an anti-pattern.

Fixes angular/material.angular.io#889.
@crisbeto crisbeto force-pushed the form-field-example-styles branch from a56218a to 612e134 Compare November 24, 2020 17:09
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jan 5, 2021
@annieyw annieyw merged commit 154ef43 into angular:master Jan 6, 2021
annieyw pushed a commit that referenced this pull request Jan 6, 2021
* Fixes an example that was referring to the `example-container` class, but wasn't actually using it.
* Uses flexbox to layout the example, instead of `br` tags which are an anti-pattern.

Fixes angular/material.angular.io#889.

(cherry picked from commit 154ef43)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Jan 14, 2021
* Fixes an example that was referring to the `example-container` class, but wasn't actually using it.
* Uses flexbox to layout the example, instead of `br` tags which are an anti-pattern.

Fixes angular/material.angular.io#889.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS tab missing for "Simple form field" example
3 participants