Skip to content

docs(material/chips): add mat-labels to examples #21126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2020
Merged

docs(material/chips): add mat-labels to examples #21126

merged 1 commit into from
Nov 25, 2020

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Nov 23, 2020 •
edited
Loading

  • add mat-labels to dev-app demos as well
  • fix demo that doesn't have 100% width

As we discussed in a team meeting a few weeks ago, the docs don't have any examples of using chips in a form field with mat-label, which is our recommended approach now that the new appearances are the default.

@Splaktar
docs(material/chips): add mat-labels to examples
cd3d573 
- add `mat-label`s to dev-app demos as well
- fix demo that doesn't have 100% width
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 23, 2020
@Splaktar Splaktar requested a review from annieyw November 23, 2020 21:13
@Splaktar Splaktar added docs This issue is related to documentation target: patch This PR is targeted for the next patch release P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Nov 23, 2020
@annieyw annieyw added action: merge The PR is ready for merge by the caretaker merge safe labels Nov 24, 2020
@annieyw annieyw merged commit 34a43f6 into angular:master Nov 25, 2020
annieyw pushed a commit that referenced this pull request Nov 25, 2020
@Splaktar @annieyw
docs(material/chips): add mat-labels to examples (#21126)
38b80c8 
- add `mat-label`s to dev-app demos as well
- fix demo that doesn't have 100% width

(cherry picked from commit 34a43f6)
@Splaktar Splaktar deleted the docs-chips-add-mat-labels branch November 25, 2020 08:07
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@annieyw annieyw annieyw approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Splaktar @annieyw