Skip to content

feat(table): expand cell harness api #21162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2020
Merged

feat(table): expand cell harness api #21162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fcd0d3
feat(table): expand cell harness api
JoepKockelkorn Nov 28, 2020
ab4897a
fix: pr comments
JoepKockelkorn Nov 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/material-experimental/mdc-table/testing/cell-harness.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@
*/

import {
ComponentHarness,
HarnessPredicate,
ComponentHarnessConstructor,
ContentContainerComponentHarness,
} from '@angular/cdk/testing';
import {CellHarnessFilters} from './table-harness-filters';

/** Harness for interacting with an MDC-based Angular Material table cell. */
export class MatCellHarness extends ComponentHarness {
export class MatCellHarness extends ContentContainerComponentHarness {
/** The selector for the host element of a `MatCellHarness` instance. */
static hostSelector = '.mat-mdc-cell';

Expand Down
4 changes: 2 additions & 2 deletions src/material/table/testing/cell-harness.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@
*/

import {
ComponentHarness,
HarnessPredicate,
ComponentHarnessConstructor,
ContentContainerComponentHarness
} from '@angular/cdk/testing';
import {CellHarnessFilters} from './table-harness-filters';

/** Harness for interacting with a standard Angular Material table cell. */
export class MatCellHarness extends ComponentHarness {
export class MatCellHarness extends ContentContainerComponentHarness {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same changes need to be made in the cell-harness under experimental.

/** The selector for the host element of a `MatCellHarness` instance. */
static hostSelector = '.mat-cell';

Expand Down
2 changes: 1 addition & 1 deletion tools/public_api_guard/material/table/testing.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ export interface CellHarnessFilters extends BaseHarnessFilters {
text?: string | RegExp;
}

export declare class MatCellHarness extends ComponentHarness {
export declare class MatCellHarness extends ContentContainerComponentHarness {
getColumnName(): Promise<string>;
getText(): Promise<string>;
static hostSelector: string;
Expand Down