fix(material/bottom-sheet): some changes not being picked up #21175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some components, like the dialog and snack bar, we had to remove `OnPush` change detection some time ago, because the views inside the component were being detected at their declaration place. These changes apply the same fix to the bottom sheet. Fixes angular#21141.
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
jelbourn
approved these changes
Nov 30, 2020
There was a problem hiding this comment.
LGTM
FWIW, I suspect that the framework bug that causes the problem is angular/angular#39545
vyrotek
added a commit
to vyrotek/angular-material-addons
that referenced
this pull request
Dec 4, 2020
Change to match official bottom-sheet ChangeDetectionStrategy. angular/components#21175
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some components, like the dialog and snack bar, we had to remove
OnPushchange detection some time ago, because the views inside the component were being detected at their declaration place.These changes apply the same fix to the bottom sheet.
Fixes #21141.