update on docs and comments for default option value for checkbox #21230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… value for checkbox updates the documentation and comments of customizing the default option of the checkbox. the default option value to provide for checkbox is MAT_CHECKBOX_DEFAULT_OPTIONS for version>=10 fixes #21025
docs(material/checkbox): updated docs and comments for default option…
adhispace
requested review from
devversion,
jelbourn and
mmalerba
as code owners
google-cla
bot
added
the
cla: yes
crisbeto
added
merge: caretaker note
|
Caretaker note: for some reason the CI didn't run on this PR. It's only doc changes so I think that we can merge it anyway. |
|
@adhispace do you happen to have CircleCI set up on your fork of angular/components? |
|
Seems like this change has conflicts with 11.0.x. Is it ok to change this to |
no, I dont have CircleCI setup in my fork. |
wagnermaciel
added
target: minor
wagnermaciel
added a commit
that referenced
this pull request
Dec 8, 2020
… value for checkbox (#21230) (#21254) updates the documentation and comments of customizing the default option of the checkbox. the default option value to provide for checkbox is MAT_CHECKBOX_DEFAULT_OPTIONS for version>=10 fixes #21025 Co-authored-by: adhispace <[email protected]>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates the documentation and comments of customizing the default option of the checkbox.
the default option value to provide for checkbox is MAT_CHECKBOX_DEFAULT_OPTIONS for version>=10
fixes #21025